Fix issue 171 interpolation image shape #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TjarkMiener
reviewed
Oct 13, 2025
| ] | ||
|
|
||
| class ImageMapper(TelescopeComponent): | ||
| class ImageMapper(Component): |
Member
There was a problem hiding this comment.
You would need to remove the passing of the subarray in line reader-L386 and reader-L393.
Member
There was a problem hiding this comment.
there are somo FIXMEs and TODOs for setting up the configuration of the ImageMapper. I can fix this in a follow-up PR. Probably the ImageMapper trait in the reader should just be a ComponentName.
Member
Author
There was a problem hiding this comment.
I will let you handle any more todos :)
TjarkMiener
reviewed
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #171
The
interpolation_image_shapeparameter can now be passed directly as an arg to mapper constructors (BilinearMapper, ...), instead of being silently ignored.Changes:
interpolation_image_shape) to be initialized from kwargs